This repository has been archived by the owner on May 15, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
[bajun-runtime] add missing migrations for production network and add migration check to CI #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lo-node (although it seems it can't be used with the solo node.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## bajun-stable #396 +/- ##
===============================================
Coverage ? 75.76%
===============================================
Files ? 33
Lines ? 3508
Branches ? 0
===============================================
Hits ? 2658
Misses ? 850
Partials ? 0 ☔ View full report in Codecov by Sentry. |
clangenb
changed the title
Introduce migration-check CI and add first batch of migrations
[bajun-runtime] add missing migrations for production network and add migration check to CI
Feb 11, 2024
DidacSF
approved these changes
Feb 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the missing storage migrations. All storage migrations are very cheap, hence they can be included into one runtime. Additionally, the CI verifies the storage migrations with try-runtime against on-chain live data.
The weight executed for the storage migration is tiny and should not pose problems. Output from the try-runtime on my machine: