Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

[ABO-216][Erdstall] Add the ability to modify parameters #382

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

DidacSF
Copy link
Contributor

@DidacSF DidacSF commented Nov 29, 2023

Description

This PR addresses the issue raised in https://ajunanetwork.atlassian.net/browse/ABO-216, to do so it adds two extrinsics:

  • set_administrator: Allows to set an account as the pallet's administrator
  • set_parameters: Allows the pallet's administrator to change the requested parameters

Type of changes

  • build: Changes that affect the build system or external dependencies (eg, Cargo, Docker)
  • ci: Changes to CI configuration
  • docs: Changes to documentation only
  • feat: Changes to add a new feature
  • fix: Changes to fix a bug
  • refactor: Changes that do not alter functionality
  • style: Changes to format the code
  • test: Changes to add missing tests or correct existing tests

Checklist

  • Tests for the changes have been added
  • Necessary documentation is added (if appropriate)
  • Formatted with cargo fmt --all
  • Linted with cargo clippy --all-features --all-targets
  • Tested with cargo test --workspace --all-features --all-targets

@DidacSF DidacSF requested a review from darkfriend77 November 29, 2023 15:02
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop-erdstall@b4c3376). Click here to learn what that means.

Additional details and impacted files
@@                 Coverage Diff                 @@
##             develop-erdstall     #382   +/-   ##
===================================================
  Coverage                    ?   75.90%           
===================================================
  Files                       ?       35           
  Lines                       ?     4030           
  Branches                    ?        0           
===================================================
  Hits                        ?     3059           
  Misses                      ?      971           
  Partials                    ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DidacSF DidacSF merged commit 48078e2 into develop-erdstall Nov 30, 2023
13 checks passed
@DidacSF DidacSF deleted the ABO-216 branch November 30, 2023 11:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants