fix type hints in faststream/specification #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lancetnik
requested changes
Dec 14, 2024
| @@ -1,3 +1,5 @@ | |||
| from faststream.specification.asyncapi.v2_6_0.schema import ServerVariable | |||
There was a problem hiding this comment.
We shouldn't reexport v2_6_0 classes here, please, reexport them in the final file like here: https://github.com/airtai/faststream/blob/0.6.0/faststream/specification/asyncapi/v3_0_0/schema/utils.py
| @@ -18,7 +18,7 @@ | |||
|
|
|||
| def parse_handler_params(call: "CallModel", prefix: str = "") -> AnyDict: | |||
| """Parses the handler parameters.""" | |||
| model = getattr(call, "serializer", call).model | |||
| model = getattr(call, "serializer", call).model # type: ignore[union-attr] | |||
There was a problem hiding this comment.
It is a FastDepends - related thing. Do not suppress it, let it be an error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mypy bugs are fixed
Type of change
Checklist
scripts/lint.shshows no errors)scripts/test-cov.shscripts/static-analysis.sh