Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Source GetLago: feat customer usage #45452

Merged
merged 5 commits into from
Sep 16, 2024
Merged

✨ Source GetLago: feat customer usage #45452

merged 5 commits into from
Sep 16, 2024

Conversation

sviande
Copy link
Contributor

@sviande sviande commented Sep 13, 2024 •
edited
Loading

What

  1. Fix import for stream customer_usage the API required the external_subscription_id
  2. The customer_usage stream only get current usage we need another stream for past usage

How

  1. customer_usage stream import from subscription stream
  2. Add a new stream for customer_usage_past API

Review guide

Import customer_usage and customer_usage_past

User Impact

Import new real customer usage and the user can import past usage.

Can this PR be safely reverted and rolled back?

  • [X ] YES 💚
  • NO ❌

@sviande
Source GetLago: import customer usage from subscription
47bdbb0 
The API need two parameters external_customer_id and
external_subscription_id

If external_subscription_id is not provided the API always return 405

https://docs.getlago.com/api-reference/customer-usage/get-current
@sviande
Source GetLago: customer usage
1495c53 
Add subcription_id, customer_id and filters on object
@sviande
Source GetLago: add new stream customer usage past
67955ed 
From reference: https://docs.getlago.com/api-reference/customer-usage/get-past
@vercel Vercel
Copy link

vercel bot commented Sep 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 3:56pm

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Sep 13, 2024
@sviande sviande temporarily deployed to community-ci-auto September 13, 2024 09:16 — with GitHub Actions Inactive
@sviande sviande temporarily deployed to community-ci-auto September 13, 2024 09:16 — with GitHub Actions Inactive
@octavia-squidington-iii octavia-squidington-iii added connectors/source/getlago area/documentation Improvements or additions to documentation labels Sep 13, 2024
@sviande sviande temporarily deployed to community-ci-auto September 13, 2024 09:20 — with GitHub Actions Inactive
@sviande sviande temporarily deployed to community-ci-auto September 13, 2024 09:20 — with GitHub Actions Inactive
@sviande sviande marked this pull request as ready for review September 13, 2024 09:26
@sviande sviande force-pushed the connector_get_lago_feat_customer_usage branch from a1dc8ff to d5bd88e Compare September 13, 2024 09:28
@sviande sviande temporarily deployed to community-ci-auto September 13, 2024 09:28 — with GitHub Actions Inactive
@sviande sviande temporarily deployed to community-ci-auto September 13, 2024 09:28 — with GitHub Actions Inactive
@sviande sviande force-pushed the connector_get_lago_feat_customer_usage branch from d5bd88e to d6b22d1 Compare September 13, 2024 13:16
@sviande sviande temporarily deployed to community-ci-auto September 13, 2024 13:17 — with GitHub Actions Inactive
@sviande sviande temporarily deployed to community-ci-auto September 13, 2024 13:17 — with GitHub Actions Inactive
@sviande sviande temporarily deployed to community-ci-auto September 13, 2024 15:52 — with GitHub Actions Inactive
@sviande sviande temporarily deployed to community-ci-auto September 13, 2024 15:52 — with GitHub Actions Inactive
marcosmarxm
marcosmarxm approved these changes Sep 14, 2024
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, running CI tests :) nice contribution @sviande

@marcosmarxm marcosmarxm merged commit bb1adbe into airbytehq:master Sep 16, 2024
34 checks passed
@sviande
Copy link
Contributor Author

sviande commented Sep 16, 2024

Thanks for the review !

@sviande sviande deleted the connector_get_lago_feat_customer_usage branch September 16, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm marcosmarxm approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/getlago
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sviande @marcosmarxm @octavia-squidington-iii