airbyte-ci: relax docs qa checks when sl == 0 #45360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
octavia-squidington-iii
added
the
area/documentation
postamar
force-pushed
the
postamar/sl-0-relaxes-doc-checks
branch
from
58495bd to
e656cd7
Compare
2 tasks
2 tasks
postamar
force-pushed
the
postamar/sl-0-relaxes-doc-checks
branch
from
e656cd7 to
e30bdce
Compare
postamar
commented
Sep 10, 2024
| == f"The dockerImageTag value ({decremented_version}) can't be decremented: it should be equal to or above {current_version}." | ||
| ) | ||
| expected_prefix = f"The dockerImageTag value ({decremented_version}) can't be decremented: it should be equal to or above" | ||
| assert error_message.startswith(expected_prefix), error_message |
There was a problem hiding this comment.
The test expects current_version to be patch version 11 instead of 13 and currently fails in master also. I looked into how it gets the current version, it reads it off dockerhub. Changing the assertion seemed more reasonable to me.
|
Thanks! #45341 is happy with these changes so I'm confident they work as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When developing new connectors, the QA checks related to documentation are annoying. For instance, there's no point in maintaining a changelog and being forced to adds needless friction.
How
Allow 0
slvalues in AirbyteInternal objects in metadata.yaml. For good measure, allow 0qlvalues also. Make docs checks applicable only tosl >= 100. 100 is the defaultslvalue anyway so this shouldn't break anything.Depends on #45361
Review guide
Commit by commit
User Impact
None
Can this PR be safely reverted and rolled back?