Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destination Databricks: Create namespace if missing in CHECK #45208

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Destination Databricks: Create namespace if missing in CHECK #45208

merged 1 commit into from
Sep 9, 2024

Conversation

gisripa
Copy link
Contributor

@gisripa gisripa commented Sep 7, 2024 •
edited
Loading

What

Fixes: https://github.com/airbytehq/airbyte-internal-issues/issues/9620

How

Made the code uniform with our existing Snowflake CHECK impl.

Review guide

  • Some diffs are due to restructuring it inside try-catch.
  • Removed explicit storageOp.prepare/write/cleanup and Rely on StreamOp.writeRecords to do both staging and table copy operation.

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel Vercel
Copy link

vercel bot commented Sep 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2024 1:08am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Sep 7, 2024
@gisripa Graphite App
Copy link
Contributor Author

gisripa commented Sep 7, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gisripa and the rest of your teammates on Graphite Graphite

@gisripa gisripa changed the title databricks-check-create-ns Destination Databricks: Create namespace if missing in CHECK Sep 7, 2024
@gisripa gisripa marked this pull request as ready for review September 7, 2024 00:57
@gisripa gisripa requested a review from a team as a code owner September 7, 2024 00:57
@gisripa gisripa force-pushed the gireesh/09-06-databricks-check-create-ns branch from 22a3a7e to cdd8407 Compare September 7, 2024 01:04
edgao
edgao approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we really need to pull this into the cdk at some point 😀

(did you try manually testing this? since we don't have an actual test for check right now)

@gisripa
Copy link
Contributor Author

gisripa commented Sep 9, 2024

(did you try manually testing this? since we don't have an actual test for check right now)

Yeah connector override in Perf workspace.

@gisripa gisripa merged commit bb1833c into master Sep 9, 2024
40 checks passed
@gisripa gisripa deleted the gireesh/09-06-databricks-check-create-ns branch September 9, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgao edgao edgao approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/databricks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gisripa @edgao @octavia-squidington-iii