bug(airbyte-cdk) Fix extras not being printed #45198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
artem1205
approved these changes
Sep 6, 2024
girarda
approved these changes
Sep 6, 2024
|
Shopify tests are failing because of this. I think it is pretty safe to merge without waiting for that. |
|
/approve-regression-tests This should not impact regression testing as it does not use the flag debug
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Since this change, extras are not printed anymore
How
Ensure the comparison on the log level match the type
User Impact
Devs will be able to see extras in the logs when running on debug mode
Can this PR be safely reverted and rolled back?