[source-mysql/mssql] Fix state manager on determining non-resumable streams #45181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
the
area/documentation
rodireich
approved these changes
Sep 10, 2024
|
@rodireich thanks for reviewing! postgres has been doing this already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
fixes https://github.com/airbytehq/oncall/issues/6204
fixes https://github.com/airbytehq/airbyte-internal-issues/issues/8820
fixes https://github.com/airbytehq/oncall/issues/6144
Some streams were not correctly categorized and caused us not sending them in state properly.
Also introduced completedNonResumableStream and will be sent in all state messsages (in fact we can either do that or just pass through all streams in state, I chose a more accurate way to do so)
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?