bulk-cdk: make exception classifiers recursive #45141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
postamar
commented
Sep 4, 2024
| unwound = unwound.cause | ||
| } | ||
| return connectorErrorException | ||
| } |
There was a problem hiding this comment.
I generalized the unwinding logic, see below
postamar
commented
Sep 4, 2024
| TransientError("barbaz"), | ||
| classifier.classify(RuntimeException("quux", RuntimeException("barbaz"))), | ||
| ) | ||
| } |
There was a problem hiding this comment.
this is a regression test
xiaohansong
approved these changes
Sep 4, 2024
airbyte-cdk/bulk/core/base/src/main/kotlin/io/airbyte/cdk/output/ExceptionClassifier.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I forgot to make the
ExceptionClassifierimplementations recursive, in terms of Exception causes. Without this, theRegexExceptionClassifierin particular is quite useless; because the interesting exceptions are usually wrapped inside other RuntimeExceptions and whatnot.How
Replicate the behaviour of the
ConnectorExceptionHandlerfrom the legacy CDK.Review guide
User Impact
None as of yet.
Can this PR be safely reverted and rolled back?