-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async job/add transformation #45135
Async job/add transformation #45135
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
airbyte-integrations/connectors/source-sendgrid/source_sendgrid/manifest.yaml
Show resolved
Hide resolved
...e-cdk/python/airbyte_cdk/sources/declarative/transformations/keys_to_lower_transformation.py
Outdated
Show resolved
Hide resolved
@@ -1686,6 +1687,19 @@ definitions: | |||
type: | |||
type: string | |||
enum: [JsonlDecoder] | |||
KeysToLower: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is KeysToLower
needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would we reference the transformation from the manifest if we don't have that?
What
As Baz (voluntarily not tagging him as I'm pretty sure he would check the PR) is on PTO and that I have no one to code review synchronously on a daily basis, I'll start creating more PRs for the async project. This is the first one where we add the transformation to lower case the keys of a record.
Note that we used this opportunity to update the typing of the transformation as the usage we've seen expect a transformation in the reference passed and this aligns with the TypeTransformer we have elsewhere too
How
Add a new transformation
Review guide
airbyte-cdk/python/airbyte_cdk/sources/declarative/transformations/keys_to_lower_transformation.py
airbyte-cdk/python/airbyte_cdk/sources/declarative/declarative_component_schema.yaml
airbyte-cdk/python/airbyte_cdk/sources/declarative/parsers/model_to_component_factory.py
Usage is shown in the sendgrid manifest
User Impact
Make the new transformation available in low-code as shown in the manifest.yaml for sendgrid in this PR. Using our sandbox environment, we have the example below:
Without transformation
With transformation
Can this PR be safely reverted and rolled back?
This is a partial PR for async jobs and hence is not meant to be merged in master directly