[source-mysqlv2] A new mysqlv2 #44606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
octavia-squidington-iii
added
area/connectors
evantahler
reviewed
Aug 30, 2024
airbyte-integrations/connectors/source-mysql-v2/src/main/resources/META-INF/LICENSE
Outdated
Show resolved
Hide resolved
postamar
reviewed
Aug 31, 2024
airbyte-integrations/connectors/source-mysql-v2/src/main/resources/application.yml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-mysql-v2/src/main/resources/application.yml
Outdated
Show resolved
Hide resolved
...ource-mysql-v2/src/test/kotlin/io/airbyte/integrations/source/mysql/MysqlContainerFactory.kt
Outdated
Show resolved
Hide resolved
| checkpointTargetIntervalSeconds = 60 | ||
| concurrency = 1 | ||
| } | ||
| } |
There was a problem hiding this comment.
FYI in case it wasn't obvious, in due time we can port over most of the functionality from the MySqlTestContainer from the legacy CDK in here.
...2/src/test/kotlin/io/airbyte/integrations/source/mysql/MysqlSourceDatatypeIntegrationTest.kt
Outdated
Show resolved
Hide resolved
.../src/test/kotlin/io/airbyte/integrations/source/mysql/MysqlSourceSelectQueryGeneratorTest.kt
Outdated
Show resolved
Hide resolved
...ource-mysql-v2/src/main/kotlin/io/airbyte/integrations/source/mysql/MysqlSourceOperations.kt
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-mysql-v2/src/test/resources/expected-spec.json
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-mysql-v2/src/test/test/resources/expected-spec.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Marius Posta <[email protected]>
Co-authored-by: Marius Posta <[email protected]>
postamar
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Foundation work for mysqlv2.
It should support discover and check on non CDC mode.
Test passed.
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?