-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(source-delighted): update end_datetime
macro
#44601
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update end_datetime so runs grab most recent data
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
Connector related issues
community
connectors/source/delighted
labels
Aug 23, 2024
cbeauch
temporarily deployed
to
community-ci-auto
August 23, 2024 16:17 — with
GitHub Actions
Inactive
cbeauch
had a problem deploying
to
community-ci-auto
August 23, 2024 16:17 — with
GitHub Actions
Failure
cbeauch
had a problem deploying
to
community-ci-auto
August 29, 2024 19:49 — with
GitHub Actions
Failure
cbeauch
had a problem deploying
to
community-ci-auto
August 29, 2024 19:49 — with
GitHub Actions
Failure
cbeauch
temporarily deployed
to
community-ci-auto
August 29, 2024 19:49 — with
GitHub Actions
Inactive
marcosmarxm
changed the title
Update end_datetime for Delighted
fix(source-delighted): update Sep 8, 2024
end_datetime
macro
octavia-squidington-iii
added
the
area/documentation
Improvements or additions to documentation
label
Sep 8, 2024
marcosmarxm
temporarily deployed
to
community-ci-auto
September 8, 2024 18:20 — with
GitHub Actions
Inactive
marcosmarxm
temporarily deployed
to
community-ci-auto
September 8, 2024 18:20 — with
GitHub Actions
Inactive
marcosmarxm
temporarily deployed
to
community-ci
September 8, 2024 18:20 — with
GitHub Actions
Inactive
marcosmarxm
temporarily deployed
to
community-ci
September 8, 2024 18:20 — with
GitHub Actions
Inactive
marcosmarxm
approved these changes
Sep 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT thanks @cbeauch !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
community
connectors/source/delighted
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update end_datetime so runs grab most recent data
What
This connector would not grab nps results submitted on the same day.
For example, today_utc() on August 23 would only sync data up to August 22.
How
Use now_utc instead of today_utc to grab all the data
Review guide
User Impact
Can this PR be safely reverted and rolled back?