Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(source-delighted): update end_datetime macro #44601

Merged
merged 3 commits into from
Sep 8, 2024

Conversation

cbeauch
Copy link
Contributor

@cbeauch cbeauch commented Aug 23, 2024

Update end_datetime so runs grab most recent data

What

This connector would not grab nps results submitted on the same day.

For example, today_utc() on August 23 would only sync data up to August 22.

How

Use now_utc instead of today_utc to grab all the data

Review guide

  1. Copy manifest into Builder
  2. Add Delighted API key
  3. Run test and view results (and request url)

User Impact

  • Users will get all data

Can this PR be safely reverted and rolled back?

  • Yes
  • YES 💚
  • NO ❌

Update end_datetime so runs grab most recent data
Copy link

vercel bot commented Aug 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 8, 2024 6:24pm

@CLAassistant
Copy link

CLAassistant commented Aug 23, 2024

CLA assistant check
All committers have signed the CLA.

@cbeauch cbeauch temporarily deployed to community-ci-auto August 29, 2024 19:49 — with GitHub Actions Inactive
@marcosmarxm marcosmarxm changed the title Update end_datetime for Delighted fix(source-delighted): update end_datetime macro Sep 8, 2024
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT thanks @cbeauch !

@marcosmarxm marcosmarxm merged commit a8e3837 into airbytehq:master Sep 8, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/delighted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants