-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚨 🚨 ✨ Source Jira: Migrate IssueComments
and IssueWorklogs
streams to low code
#38612
🚨 🚨 ✨ Source Jira: Migrate IssueComments
and IssueWorklogs
streams to low code
#38612
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
80b67b6
to
1cf7ca9
Compare
docs/integrations/sources/jira.md
Outdated
@@ -127,6 +127,7 @@ The Jira connector should not run into Jira API limitations under normal usage. | |||
|
|||
| Version | Date | Pull Request | Subject | | |||
|:--------|:-----------|:-----------------------------------------------------------|:-----------------------------------------------------------------------------------------------------------------------------------------------------------------| | |||
| 3.1.0 | 2024-08-16 | [38612](https://github.com/airbytehq/airbyte/pull/38612) | Migrate IssueComments and IssueWorklogs streams to low code | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's be super clear that this is not revertible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the message
1cf7ca9
to
0e17388
Compare
0e17388
to
9b95d9e
Compare
9b95d9e
to
7b26c3a
Compare
Regression tests - https://github.com/airbytehq/airbyte/actions/runs/11554415703/job/32157573020 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'm just wondering why we emit so many more state messages in the new version based on the regression tests here
The difference in state count is due to the Python implementation previously emitting state messages at intervals, whereas now we emit them after every slice. |
What
Migrate
IssueComments
andIssueWorklogs
streams to low code based on the CDK update to add an incremental dependency to the parent stream. Corresponding CDK PR: #38211How
The
IssueComments
andIssueWorklogs
streams have been migrated to low code. Their parent stream, Issues, will now be read incrementally using the state from the child streams. The parent state will be saved to the child state.User Impact
This change is not reversible.
This PR introduces a breaking change due to the state format modification. Migration to the new version will be done automatically, but the new state format is incompatible with the previous version. The first sync after migration may be slow as the connector needs to reread all parent records.
Old state format:
New state format:
Can this PR be safely reverted and rolled back?