Rename defaultNamespace to prefix and make it optional #2350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgardens
approved these changes
Mar 8, 2021
There was a problem hiding this comment.
The API interface configuration is still marking the prefix field as required. That's not what we want, right? After that is fixed, it looks good. It looks like you're changing stuff on the FE too. Probably means @jamakase doesn't need to do anything (other than review this PR)
michel-tricot
approved these changes
Mar 8, 2021
| // TODO chris: use defaultNamespace as a namespace/schema/dataset in destination | ||
| return defaultNamespace + streamName; | ||
| private static String transformStreamName(final String streamName, final String prefix) { | ||
| if (prefix != null && !prefix.isEmpty()) { |
There was a problem hiding this comment.
Strings.isEmpty or smthing like that does the same
Co-authored-by: Charles <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Describe what the change is solving
Closes #2335
How
Describe the solution
Rename defaultNamespace to prefix