have temporal workers return unwrapped objects #2318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgardens
changed the base branch from
master
to
cgardens/get_spec_temporal_fixes
Base automatically changed from
cgardens/get_spec_temporal_fixes
to
cgardens/check_connection_worker_on_temporal
March 5, 2021 01:38
Base automatically changed from
cgardens/check_connection_worker_on_temporal
to
master
March 5, 2021 02:30
cgardens
force-pushed
the
cgardens/tng_worker
branch
2 times, most recently
from
0cb63dd to
550d000
Compare
cgardens
force-pushed
the
cgardens/tng_worker
branch
from
550d000 to
b0b8d46
Compare
cgardens
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We used to wrap the output of workers in
OutputAndStatusbut this wrapper no longer makes sense in the worker. We keep it around in the scheduler since it is specific to how we track asynchronous jobs. Workers now just worry about returning the type they are built for.Worker
Basically removed
OutputAndStatuseverywhere. It's not used on the worker side at this point so it's a pretty boring change. I'm splitting it out so that the next PR (which is actually interesting) will be smaller and easier to read.