Track new connection: #2260
Track new connection: #2260
Conversation
…en not anonymized #2163
| @@ -95,6 +95,9 @@ public void track(String action, Map<String, Object> metadata) { | |||
| final Map<String, Object> mapCopy = new HashMap<>(metadata); | |||
| final TrackingIdentity trackingIdentity = identitySupplier.get(); | |||
| mapCopy.put(AIRBYTE_VERSION_KEY, trackingIdentity.getAirbyteVersion()); | |||
| if (metadata.containsKey(USER_EMAIL_KEY_PLACEHOLDER) && metadata.get(USER_EMAIL_KEY_PLACEHOLDER).equals(USER_EMAIL_VALUE_PLACEHOLDER)) { | |||
There was a problem hiding this comment.
Option1: I put this little placeholder trick so we can tweak if we want to inject user email or not...
Option2: If we are okay with always sending user email for both "Connector Jobs" and "New Connection - Backend", then this is not needed...
Option3: This could also be solved with a new method in the interface TrackingClient? trackWithEmail?
(as commented here: #2163 (comment))
There was a problem hiding this comment.
@cgardens just want to make sure we are not storing the email if someone opted out.
There was a problem hiding this comment.
I am in favor of option2 let's keeps things simple, we can always revisit if needed
There was a problem hiding this comment.
I'm ok with option 2. are you okay with it @cgardens ?
There was a problem hiding this comment.
yeah. option 2 sounds good.
airbyte-analytics/src/main/java/io/airbyte/analytics/TrackingClient.java
Outdated
Show resolved
Hide resolved
| @@ -95,6 +95,9 @@ public void track(String action, Map<String, Object> metadata) { | |||
| final Map<String, Object> mapCopy = new HashMap<>(metadata); | |||
| final TrackingIdentity trackingIdentity = identitySupplier.get(); | |||
| mapCopy.put(AIRBYTE_VERSION_KEY, trackingIdentity.getAirbyteVersion()); | |||
| if (metadata.containsKey(USER_EMAIL_KEY_PLACEHOLDER) && metadata.get(USER_EMAIL_KEY_PLACEHOLDER).equals(USER_EMAIL_VALUE_PLACEHOLDER)) { | |||
There was a problem hiding this comment.
@cgardens just want to make sure we are not storing the email if someone opted out.
| @@ -95,6 +95,9 @@ public void track(String action, Map<String, Object> metadata) { | |||
| final Map<String, Object> mapCopy = new HashMap<>(metadata); | |||
| final TrackingIdentity trackingIdentity = identitySupplier.get(); | |||
| mapCopy.put(AIRBYTE_VERSION_KEY, trackingIdentity.getAirbyteVersion()); | |||
| if (metadata.containsKey(USER_EMAIL_KEY_PLACEHOLDER) && metadata.get(USER_EMAIL_KEY_PLACEHOLDER).equals(USER_EMAIL_VALUE_PLACEHOLDER)) { | |||
There was a problem hiding this comment.
I am in favor of option2 let's keeps things simple, we can always revisit if needed
airbyte-analytics/src/main/java/io/airbyte/analytics/TrackingClient.java
Outdated
Show resolved
Hide resolved
This check is made here: |
What
Describe what the change is solving
Closes #2163
How
Describe the solution