Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only add temporal #2259

Merged
merged 7 commits into from
Mar 3, 2021
Merged

only add temporal #2259

merged 7 commits into from
Mar 3, 2021

Conversation

jrhizor
Copy link
Contributor

@jrhizor jrhizor commented Mar 2, 2021

Extract only the parts of https://github.com/airbytehq/airbyte/pull/2130/files needed to run temporal.

todo:

  • clean up the docker compose file
  • improve config defaults
  • use same db container
  • add a getter for the client that waits until the temporal service is available couldn't replicate

@jrhizor
Copy link
Contributor Author

jrhizor commented Mar 2, 2021

We don't need to create the admin tools if we run docker run --rm --network=host temporalio/tctl:1.7.0 COMMAND separately. We should document this in the temporal maintenance section.

We can also run the web UI on demand with docker run --rm -p 8088:8088 temporalio/web:1.7.0

@jrhizor jrhizor requested review from cgardens and davinchia March 2, 2021 23:55
@jrhizor jrhizor marked this pull request as ready for review March 2, 2021 23:55
Copy link
Contributor

@michel-tricot michel-tricot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -3,6 +3,8 @@ plugins {
}

dependencies {
implementation 'io.temporal:temporal-sdk:1.0.4'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question for my own understanding: we place external dependencies above internal ones?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we actually usually do internal and then external.

(within each group we alphabetize)

main internal

main external

test internal

test external

integrationTest internal

integrationTest external

@jrhizor jrhizor merged commit e0e89ba into master Mar 3, 2021
@jrhizor jrhizor deleted the jrhizor/only-add-temporal branch March 3, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants