-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
only add temporal #2259
only add temporal #2259
Conversation
We don't need to create the admin tools if we run We can also run the web UI on demand with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -3,6 +3,8 @@ plugins { | |||
} | |||
|
|||
dependencies { | |||
implementation 'io.temporal:temporal-sdk:1.0.4' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question for my own understanding: we place external dependencies above internal ones?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we actually usually do internal and then external.
(within each group we alphabetize)
main internal
main external
test internal
test external
integrationTest internal
integrationTest external
Extract only the parts of https://github.com/airbytehq/airbyte/pull/2130/files needed to run temporal.
todo:
add a getter for the client that waits until the temporal service is availablecouldn't replicate