Add pre/post hooks for std tests #2233
Conversation
sherifnada
requested review from
cgardens,
ChristopheDuong,
jrhizor and
michel-tricot
| '--spec', "${targetMountDirectory}/${config.specPath}", | ||
| '--config', "${targetMountDirectory}/${config.configPath}", | ||
| ] | ||
| config.prehook.call() |
There was a problem hiding this comment.
Why not put this in the try? Seems like the prehook may do some things that need to be cleaned up even if it fails.
There was a problem hiding this comment.
I am getting super nervous by the amount of logic we put in gradle at the moment.
What is the longer term vision here?
There was a problem hiding this comment.
why isn't his running in the docker container that you're running instead of in gradle / outside of a controlled docker environment?
There was a problem hiding this comment.
The docker container run here executes tests which are configured via files. In case we need to say, run and stop a docker container in pre/post hooks (in this case used for Mongo testing), this seems like the most ergonomic way to declare pre/post hooks which start/stop the DB image assuming we don't have language specific bindings. These hooks are better used to run docker images, not arbitrary code. I could change the interface to say, take as input a docker image instead of run freeform code, but I think this gets wonky if the user wants to pass options to the docker command.
We could declare these in language-specific bindings (similar to what we do in python) but this is really meant as an escape hatch for languages for which we don't have those bindings (in this case Ruby).
What
Adds pre/post hooks that can be run for file-based standard tests. This allows configuring inputs to the test and cleaning them up afterwards.
The first use case will be in the Mongodb PR #2125 to init and tear down the dockerized DB. See an example usage https://github.com/narrative-bi/airbyte/pull/2