chore: use correct image pull secret. (#13151)

The current change was a P0 hot fix to make sure the right configuration was passed in. To save time, I used what was already present. Here we do so correctly.
airbytehq · Jul 18, 2024 · 86c6955 · 86c6955
1 parent 74b7096
commit 86c6955
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/airbyte-workload-launcher/src/main/kotlin/config/ContainerConfigBeanFactory.kt b/airbyte-workload-launcher/src/main/kotlin/config/ContainerConfigBeanFactory.kt
@@ -238,6 +238,15 @@ class ContainerConfigBeanFactory {
       }
   }
 
+  @Singleton
+  @Named("replicationImagePullSecrets")
+  fun replicationImagePullSecrets(
+    @Named("replicationWorkerConfigs") workerConfigs: WorkerConfigs,
+  ): List<LocalObjectReference> {
+    return workerConfigs.jobImagePullSecrets
+      .map { imagePullSecret -> LocalObjectReference(imagePullSecret) }
+  }
+
   @Singleton
   @Named("checkImagePullSecrets")
   fun checkImagePullSecrets(

diff --git a/airbyte-workload-launcher/src/main/kotlin/pods/factories/OrchestratorPodFactory.kt b/airbyte-workload-launcher/src/main/kotlin/pods/factories/OrchestratorPodFactory.kt
@@ -34,7 +34,7 @@ class OrchestratorPodFactory(
   private val orchestratorEnvSingleton: OrchestratorEnvSingleton,
   @Value("\${airbyte.worker.job.kube.serviceAccount}") private val serviceAccount: String?,
   @Named("orchestratorContainerPorts") private val containerPorts: List<ContainerPort>,
-  @Named("discoverImagePullSecrets") private val imagePullSecrets: List<LocalObjectReference>,
+  @Named("replicationImagePullSecrets") private val imagePullSecrets: List<LocalObjectReference>,
   private val volumeFactory: VolumeFactory,
   private val initContainerFactory: InitContainerFactory,
 ) {