chore: delete use stream attempt metadata feature flag (#13090)

airbytehq · Jul 12, 2024 · 815b133 · 815b133
1 parent 3c6d993
commit 815b133
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 15 deletions.
diff --git a/airbyte-commons-worker/src/main/java/io/airbyte/workers/ReplicationInputHydrator.java b/airbyte-commons-worker/src/main/java/io/airbyte/workers/ReplicationInputHydrator.java
@@ -36,11 +36,9 @@
 import io.airbyte.config.secrets.SecretsRepositoryReader;
 import io.airbyte.config.secrets.persistence.RuntimeSecretPersistence;
 import io.airbyte.featureflag.AutoBackfillOnNewColumns;
-import io.airbyte.featureflag.Connection;
 import io.airbyte.featureflag.FeatureFlagClient;
 import io.airbyte.featureflag.Organization;
 import io.airbyte.featureflag.UseRuntimeSecretPersistence;
-import io.airbyte.featureflag.UseStreamAttemptMetadata;
 import io.airbyte.featureflag.Workspace;
 import io.airbyte.metrics.lib.ApmTraceUtils;
 import io.airbyte.persistence.job.models.ReplicationInput;
@@ -119,17 +117,15 @@ public ReplicationInput getHydratedReplicationInput(final ReplicationActivityInp
           getUpdatedStateForBackfill(state, replicationActivityInput.getSchemaRefreshOutput(), replicationActivityInput.getConnectionId(), catalog);
     }
 
-    if (featureFlagClient.boolVariation(UseStreamAttemptMetadata.INSTANCE, new Connection(replicationActivityInput.getConnectionId()))) {
-      try {
-        trackBackfillAndResume(
-            jobId,
-            replicationActivityInput.getJobRunConfig().getAttemptId(),
-            resumableFullRefreshStatsHelper.getStreamsWithStates(state).stream().toList(),
-            streamsToBackfill);
-      } catch (final Exception e) {
-        LOGGER.error("Failed to track stream metadata for connectionId:{} attempt:{}", replicationActivityInput.getConnectionId(),
-            replicationActivityInput.getJobRunConfig().getAttemptId(), e);
-      }
+    try {
+      trackBackfillAndResume(
+          jobId,
+          replicationActivityInput.getJobRunConfig().getAttemptId(),
+          resumableFullRefreshStatsHelper.getStreamsWithStates(state).stream().toList(),
+          streamsToBackfill);
+    } catch (final Exception e) {
+      LOGGER.error("Failed to track stream metadata for connectionId:{} attempt:{}", replicationActivityInput.getConnectionId(),
+          replicationActivityInput.getJobRunConfig().getAttemptId(), e);
     }
 
     // Hydrate the secrets.

diff --git a/airbyte-featureflag/src/main/kotlin/FlagDefinitions.kt b/airbyte-featureflag/src/main/kotlin/FlagDefinitions.kt
@@ -191,5 +191,3 @@ object WorkloadLauncherEnabled : EnvVar(envVar = "WORKLOAD_LAUNCHER_ENABLED", de
 object WorkloadApiServerEnabled : EnvVar(envVar = "WORKLOAD_API_SERVER_ENABLED", default = false)
 
 object DiscoverPostprocessInTemporal : Permanent<Boolean>(key = "platform.discover-postprocess-in-temporal", default = false)
-
-object UseStreamAttemptMetadata : Temporary<Boolean>(key = "platform.use-stream-attempt-metadata", default = false)
Original file line number	Diff line number	Diff line change
Expand Up		@@ -191,5 +191,3 @@ object WorkloadLauncherEnabled : EnvVar(envVar = "WORKLOAD_LAUNCHER_ENABLED", de
		object WorkloadApiServerEnabled : EnvVar(envVar = "WORKLOAD_API_SERVER_ENABLED", default = false)

		object DiscoverPostprocessInTemporal : Permanent<Boolean>(key = "platform.discover-postprocess-in-temporal", default = false)

		object UseStreamAttemptMetadata : Temporary<Boolean>(key = "platform.use-stream-attempt-metadata", default = false)