fix: don't send status if source exited with non zero (#13190)

airbytehq · Jul 21, 2024 · 67ec502 · 67ec502
1 parent b072cfe
commit 67ec502
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 13 deletions.
diff --git a/...commons-worker/src/main/kotlin/io/airbyte/workers/helper/StreamStatusCompletionTracker.kt b/...commons-worker/src/main/kotlin/io/airbyte/workers/helper/StreamStatusCompletionTracker.kt
@@ -46,14 +46,10 @@ class StreamStatusCompletionTracker(
     exitCode: Int,
     namespacingMapper: AirbyteMapper,
   ): List<AirbyteMessage> {
-    if (!shouldEmitStreamStatus) {
+    if (!shouldEmitStreamStatus || exitCode != 0) {
       return listOf()
     }
-    return if (0 == exitCode) {
-      streamDescriptorsToCompleteStatusMessage(hasCompletedStatus.keys, namespacingMapper)
-    } else {
-      streamDescriptorsToCompleteStatusMessage(hasCompletedStatus.filter { it.value }.keys, namespacingMapper)
-    }
+    return streamDescriptorsToCompleteStatusMessage(hasCompletedStatus.keys, namespacingMapper)
   }
 
   private fun streamDescriptorsToCompleteStatusMessage(

diff --git a/...ons-worker/src/test/kotlin/io/airbyte/workers/helper/StreamStatusCompletionTrackerTest.kt b/...ons-worker/src/test/kotlin/io/airbyte/workers/helper/StreamStatusCompletionTrackerTest.kt
@@ -112,17 +112,12 @@ internal class StreamStatusCompletionTrackerTest {
   }
 
   @Test
-  fun `test that we get the status of the streams that send a status if the exit code is 1 and no stream status is send`() {
+  fun `test that we get not stream status if the exit code is 1 even the source emitted some stream status`() {
     streamStatusCompletionTracker.startTracking(catalog, true)
     streamStatusCompletionTracker.track(getStreamStatusCompletedMessage("name1").trace.streamStatus)
     val result = streamStatusCompletionTracker.finalize(1, mapper)
 
-    assertEquals(
-      listOf(
-        getStreamStatusCompletedMessage("name1"),
-      ),
-      result,
-    )
+    assertEquals(listOf<AirbyteMessage>(), result)
   }
 
   @Test