-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add cli
module to api docs
#564
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request introduces modifications to the Changes
Sequence DiagramsequenceDiagram
participant User
participant CLI as PyAirbyte CLI
participant Connector as Airbyte Connector
User->>CLI: Run command (validate/benchmark/sync)
CLI->>Connector: Execute selected operation
Connector-->>CLI: Return operation results
CLI-->>User: Display results
A couple of friendly suggestions for the author:
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@coderabbitai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
airbyte/__init__.py (1)
Line range hint
1-196
: Documentation update needed for CLI moduleI notice that while we're adding the CLI module to the public API, it's not listed in the module documentation section with the other modules (like
airbyte.cloud
,airbyte.caches
, etc.). Should we add a section about the CLI module to maintain consistency with the documentation structure?Here's a suggested addition to the module list (around line 65):
- **`airbyte.cloud`** - Working with Airbyte Cloud, including running jobs remotely. +- **`airbyte.cli`** - Command Line Interface functionality for interacting with Airbyte from the terminal. - **`airbyte.caches`** - Working with caches, including how to inspect a cache and get data from it.
wdyt about adding this documentation to help users discover the CLI functionality?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
airbyte/__init__.py
(2 hunks)airbyte/cli.py
(5 hunks)
✅ Files skipped from review due to trivial changes (1)
- airbyte/cli.py
Adds new docs page for CLI:
https://airbytehq.github.io/PyAirbyte/airbyte/cli.html
Summary by CodeRabbit
New Features
cli
module is now part of the public API, allowing direct imports from theairbyte
namespace.Documentation
cli
function.Bug Fixes
cli
module.