Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eslint config] [base] [breaking] support eslint 8 #2495

Merged
merged 6 commits into from
Nov 9, 2021
Merged

[eslint config] [base] [breaking] support eslint 8 #2495

merged 6 commits into from
Nov 9, 2021

Conversation

ljharb
Copy link
Collaborator

@ljharb ljharb commented Nov 9, 2021

Technically this wouldn't have to be a semver-major change - we could hold off on enabling the many rules that have been waiting for it, only run eslint-find-rules (which was forced to make a breaking change due to API changes in eslint 8) on eslint 7 and 8, and release as a semver-minor.

However, I'm not sure there'd be much value in that - lots of people will update to get eslint 8 support, so it's a nice opportunity to add "exports" and enable more useful rules and get maximum exposure for that. Separately, at this point I'm not sure who's still using eslint 5 or 6, considering how much new syntax requires eslint 7 or 8 to support (even via babel's or typescript's eslint parser) and how hungry people often are for new syntax.

Due to the way we share packages in this quasi-monorepo, I've been forced to disable a number of tests. These will be re-enabled once I open the PR to update the react config (after the base config is published) which hopefully won't be too long (and I won't be making any meaningful changes to the react config during that gap anyways).

This resolves part of #2478.

Verified

This commit was signed with the committer’s verified signature.
ljharb Jordan Harband

Verified

This commit was signed with the committer’s verified signature.
ljharb Jordan Harband

Verified

This commit was signed with the committer’s verified signature.
ljharb Jordan Harband

Verified

This commit was signed with the committer’s verified signature.
ljharb Jordan Harband

Verified

This commit was signed with the committer’s verified signature.
ljharb Jordan Harband
@ljharb ljharb mentioned this pull request Nov 9, 2021
22 tasks

Verified

This commit was signed with the committer’s verified signature.
ljharb Jordan Harband
@ljharb
Copy link
Collaborator Author

ljharb commented Nov 9, 2021

Going to go ahead and merge and release; any problems can be addressed in patch releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant