-
Notifications
You must be signed in to change notification settings - Fork 26.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eslint config] [minor] Loosen allowed version range for eslint-plugin-react-hooks
#2207
Conversation
eslint-plugin-react-hooks
eslint-plugin-react-hooks
I think that v4 should also be allowed, as it contains no API changes: https://github.com/facebook/react/blob/master/packages/eslint-plugin-react-hooks/CHANGELOG.md |
@@ -68,7 +68,7 @@ | |||
"eslint-plugin-import": "^2.20.1", | |||
"eslint-plugin-jsx-a11y": "^6.2.3", | |||
"eslint-plugin-react": "^7.19.0", | |||
"eslint-plugin-react-hooks": "^2.3.0 || ^1.7.0", | |||
"eslint-plugin-react-hooks": "^4.0.0 || ^3.0.0 || ^2.3.0 || ^1.7.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"eslint-plugin-react-hooks": "^4.0.0 || ^3.0.0 || ^2.3.0 || ^1.7.0", | |
"eslint-plugin-react-hooks": "^4 || ^3 || ^2.3.0 || ^1.7.0", |
the same line must be duplicated in peerDependencies - otherwise you haven't actually allowed anything :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, that's right 😅 Thank you for correcting my mistake!
…d v4 Co-authored-by: Kristóf Poduszló <[email protected]> Co-authored-by: Jordan Harband <[email protected]>
Hi folks Out of curiosity, I noticed that this PR got merged but is this going to be release now or with the eslint 7 support (#2223)? Thanks again |
It will be released along with #2223. |
As seen by comparing changes between
[email protected]
and3.0.0
:The only breaking change seems to be facebook/react@d3368be. Also, a notable change is that a recommended configuration has been added:
It's almost identical to the current rules in place, as applicable by extending
airbnb/hooks
. The list of available rules hasn't changed since v2, hence no additional changes should be required.Fixes #2231.