-
Notifications
You must be signed in to change notification settings - Fork 26.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eslint v5 support #1834
Comments
Depends on airbnb/javascript#1834. Signed-off-by: Kevin Locke <[email protected]>
Thank you for the great work. It looks like the remaining tasks on the list are the publishing tasks. Do you have any estimates on when to expect the new version to be published? |
I'm waiting on a few bugs (that i've just added). |
Hey @ljharb, curious what that status is on this. I saw some bugfixes landed in jsx-a11y-plugin. |
I would love to read why "react/jsx-one-expression-per-line" is enabled. Is there a trend for developers to rotate their monitors vertically after this change 😆 This changes one readable line
to an uncomfortable syntax
|
@danactive That rule was turned off in b6a268f. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
eslint-config-airbnb v17.1.0 and eslint-config-airbnb-base v13.1.0 have been released, with eslint 5 support. |
Yeah! |
Is anyone still having the same issue after upgrading? Here are my devDependencies, but I am still running into the same issue. `
` Am I doing something wrong? |
@kmaitski what does Either way, please file a new issue if you're still having trouble. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Bump to the compatible versions listed in airbnb/javascript#1834.
Bump to the compatible versions listed in airbnb/javascript#1834.
Just like #1447, I'm filing this in advance.
v17.0.0 of
eslint-config-airbnb
and v13.0.0 ofeslint-config-airbnb-base
have just been released.eslint v5 is planned to be released in the next 24-48 hours, and the plan for our configs will be to either support v3 || v4 || v5, or, if necessary, to drop support for v3 and/or v4 as part of this release.
The timeframe is "probably not as soon as you would like, but as soon as we can".
Please accept this, and please add no noise to this thread beyond emoji reactions - distractions won't help anyone get the work done any faster.
Please do not file additional issues and do not file pull requests attempting to add support - please, instead, continue to use eslint v4 until such time as our configs support v5.
Peer Dep eslint combined v3 and v4 and v5 support released, or v5 support released (depending on which path we need to take):
eslint-plugin-import
eslint-find-rules
eslint-plugin-react
eslint-plugin-jsx-a11y
The text was updated successfully, but these errors were encountered: