Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve typing for under_cached_property decorator #38

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 7, 2024

No description provided.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 7, 2024
src/propcache/_helpers_py.py Dismissed Show dismissed Hide dismissed
src/propcache/_helpers_py.py Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.27%. Comparing base (825020d) to head (9194479).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/propcache/_helpers_py.py 90.90% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage   88.38%   88.27%   -0.11%     
==========================================
  Files          17       17              
  Lines         680      691      +11     
  Branches       63       67       +4     
==========================================
+ Hits          601      610       +9     
  Misses         63       63              
- Partials       16       18       +2     
Flag Coverage Δ
CI-GHA 88.27% <90.90%> (-0.11%) ⬇️
MyPy 72.31% <59.09%> (+0.05%) ⬆️
OS-Linux 98.37% <92.30%> (-0.32%) ⬇️
OS-Windows 93.60% <92.30%> (-0.34%) ⬇️
OS-macOS 94.13% <92.30%> (-0.29%) ⬇️
Py-3.10.11 92.83% <84.61%> (-0.61%) ⬇️
Py-3.10.15 95.43% <84.61%> (-0.63%) ⬇️
Py-3.11.10 95.43% <84.61%> (-0.63%) ⬇️
Py-3.11.9 92.83% <84.61%> (-0.61%) ⬇️
Py-3.12.6 95.43% <84.61%> (-0.63%) ⬇️
Py-3.13.0-rc.3 95.43% <84.61%> (-0.63%) ⬇️
Py-3.8.10 93.13% <84.61%> (-0.62%) ⬇️
Py-3.8.18 95.75% <84.61%> (-0.63%) ⬇️
Py-3.9.13 92.81% <84.61%> (-0.62%) ⬇️
Py-3.9.20 95.42% <84.61%> (-0.63%) ⬇️
Py-pypy7.3.11 95.47% <84.61%> (-0.73%) ⬇️
Py-pypy7.3.16 95.09% <84.61%> (-0.73%) ⬇️
Py-pypy7.3.17 95.11% <84.61%> (-0.73%) ⬇️
VM-macos-latest 94.13% <92.30%> (-0.29%) ⬇️
VM-ubuntu-latest 98.37% <92.30%> (-0.32%) ⬇️
VM-windows-latest 93.60% <92.30%> (-0.34%) ⬇️
pytest 98.37% <92.30%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco force-pushed the improve_under_cached_property_typing branch from 6f3a245 to 9194479 Compare October 7, 2024 03:09
@bdraco bdraco marked this pull request as ready for review October 7, 2024 03:18
@bdraco bdraco merged commit 416a3b2 into master Oct 7, 2024
48 of 49 checks passed
@bdraco bdraco deleted the improve_under_cached_property_typing branch October 7, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants