Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust imports to ensure wildcard imports are prohibited #32

Merged
merged 3 commits into from
Oct 6, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 6, 2024

What do these changes do?

We do not want to support wildcard imports, make sure they do not work.

Note that I did not mark this as a breaking change as this library is too new and I don't think anyone else is using it yet.

#24 (comment)

Are there changes in behavior for the user?

Wildcard imports are no longer supported

Related issue number

bdraco added 2 commits October 6, 2024 17:54
We do not want to support wildcard imports, make sure they do not work

#24 (comment)
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 6, 2024
Copy link

codecov bot commented Oct 6, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.54%. Comparing base (f7ac8b1) to head (a4242dc).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/propcache/__init__.py 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   87.50%   87.54%   +0.04%     
==========================================
  Files          22       22              
  Lines         768      771       +3     
  Branches       65       63       -2     
==========================================
+ Hits          672      675       +3     
  Misses         68       68              
  Partials       28       28              
Flag Coverage Δ
CI-GHA 87.54% <90.90%> (+0.04%) ⬆️
MyPy 67.72% <72.72%> (+0.10%) ⬆️
OS-Linux 98.67% <100.00%> (+<0.01%) ⬆️
OS-Windows 93.89% <100.00%> (+0.04%) ⬆️
OS-macOS 94.38% <100.00%> (+0.03%) ⬆️
Py-3.10.11 93.39% <100.00%> (+0.04%) ⬆️
Py-3.10.15 96.03% <100.00%> (+0.02%) ⬆️
Py-3.11.10 96.03% <100.00%> (+0.02%) ⬆️
Py-3.11.9 93.39% <100.00%> (+0.04%) ⬆️
Py-3.12.6 95.93% <100.00%> (+0.02%) ⬆️
Py-3.13.0-rc.3 95.93% <100.00%> (+0.02%) ⬆️
Py-3.8.10 93.70% <100.00%> (+0.04%) ⬆️
Py-3.8.18 96.35% <100.00%> (+0.02%) ⬆️
Py-3.9.13 93.37% <100.00%> (+0.04%) ⬆️
Py-3.9.20 96.02% <100.00%> (+0.02%) ⬆️
Py-pypy7.3.11 96.16% <100.00%> (+0.02%) ⬆️
Py-pypy7.3.16 95.78% <100.00%> (+0.03%) ⬆️
Py-pypy7.3.17 95.80% <100.00%> (+0.03%) ⬆️
VM-macos-latest 94.38% <100.00%> (+0.03%) ⬆️
VM-ubuntu-latest 98.67% <100.00%> (+<0.01%) ⬆️
VM-windows-latest 93.89% <100.00%> (+0.04%) ⬆️
pytest 98.54% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit d85d326 into master Oct 6, 2024
48 of 49 checks passed
@bdraco bdraco deleted the import_cleanups branch October 6, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants