Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leverage pytest-asyncio test discovery mode auto #1233

Conversation

jakob-keller
Copy link
Collaborator

@jakob-keller jakob-keller commented Dec 15, 2024

Description of Change

Removes @pytest.mark.asynciodecorators from test functions, in line with pytest-asyncio recommendation.

Cherry picked from @thehesiod: f7a2f75

Assumptions

Replace this text with any assumptions made (if any)

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.05%. Comparing base (e7d6ddf) to head (872ccc3).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1233      +/-   ##
==========================================
- Coverage   86.16%   86.05%   -0.12%     
==========================================
  Files          64       64              
  Lines        5986     5801     -185     
==========================================
- Hits         5158     4992     -166     
+ Misses        828      809      -19     
Flag Coverage Δ
unittests 86.05% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakob-keller jakob-keller marked this pull request as ready for review December 15, 2024 10:07
@jakob-keller
Copy link
Collaborator Author

Will follow up with more comprehensive PR

@jakob-keller jakob-keller deleted the pytest-asyncio-auto-discovery branch December 15, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant