Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code -> InstalledCode #93

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Code -> InstalledCode #93

merged 2 commits into from
Dec 9, 2024

Conversation

danielhollas
Copy link
Collaborator

@danielhollas danielhollas commented Dec 9, 2024

Use InstalledCode instead of the deprecated Code class.

In the archive_cache fixture, monkeypatch AbstractCode class, which should take care of both InstalledCode and Code since none of them have overriden the get_objects_to_hash function.

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.73%. Comparing base (045e178) to head (9ffc19f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #93   +/-   ##
=======================================
  Coverage   92.73%   92.73%           
=======================================
  Files           9        9           
  Lines         454      454           
=======================================
  Hits          421      421           
  Misses         33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielhollas danielhollas marked this pull request as ready for review December 9, 2024 11:16
@danielhollas danielhollas merged commit c4d217a into main Dec 9, 2024
7 checks passed
@danielhollas danielhollas deleted the installed-code branch December 9, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants