Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid cli redundant log in stdout (#19371) #379

Merged
merged 1 commit into from
Feb 10, 2024
Merged

fix: avoid cli redundant log in stdout (#19371) #379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG-Agoric.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ Ref: https://keepachangelog.com/en/1.0.0/

* Agoric/agoric-sdk#8871 Have `tx gov submit-proposal` accept either new or legacy syntax

### Bug Fixes

* (crypto) [#19371](https://github.com/cosmos/cosmos-sdk/pull/19371) Avoid cli redundant log in stdout, log to stderr instead.

## `v0.46.16-alpha.agoric.1` - 2024-02-05

* Agoric/agoric-sdk#8224 Merge [cosmos/cosmos-sdk v0.46.16](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.46.16)
Expand Down
4 changes: 2 additions & 2 deletions crypto/keyring/keyring.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -856,7 +856,7 @@ func (ks keystore) MigrateAll() ([]*Record, error) {

rec, err := ks.migrate(key)
if err != nil {
fmt.Printf("migrate err for key %s: %q\n", key, err)
fmt.Fprintf(os.Stderr, "migrate err for key %s: %q\n", key, err)
continue
}

Expand Down Expand Up @@ -926,7 +926,7 @@ func (ks keystore) migrate(key string) (*Record, error) {
return nil, fmt.Errorf("unable to set keyring.Item, err: %w", err)
}

fmt.Printf("Successfully migrated key %s.\n", key)
fmt.Fprintf(os.Stderr, "Successfully migrated key %s.\n", key)

return k, nil
}
Expand Down
Loading