Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid cli redundant log in stdout (#19371) #379

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

JimLarson
Copy link

@JimLarson JimLarson commented Feb 10, 2024

Description

Refs: Agoric/agoric-sdk#8885

Backport of cosmos#19371

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@JimLarson JimLarson added bug Something isn't working agoric-cosmos Agoric tags for cosmos labels Feb 10, 2024
@JimLarson JimLarson requested a review from mhofman February 10, 2024 00:21
@JimLarson JimLarson self-assigned this Feb 10, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (aa291d8) 66.08% compared to head (84d5de0) 66.11%.
Report is 1 commits behind head on Agoric.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           Agoric     #379      +/-   ##
==========================================
+ Coverage   66.08%   66.11%   +0.02%     
==========================================
  Files         668      668              
  Lines       73007    73007              
==========================================
+ Hits        48248    48266      +18     
+ Misses      22103    22084      -19     
- Partials     2656     2657       +1     
Files Coverage Δ
crypto/keyring/keyring.go 63.04% <50.00%> (ø)

... and 1 file with indirect coverage changes

@JimLarson JimLarson merged commit f42d869 into Agoric Feb 10, 2024
38 of 39 checks passed
@JimLarson JimLarson deleted the mhofman/backport-19371 branch February 10, 2024 00:43
mhofman added a commit to Agoric/agoric-sdk that referenced this pull request Feb 12, 2024
mhofman added a commit to Agoric/agoric-sdk that referenced this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agoric-cosmos Agoric tags for cosmos bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants