forked from cosmos/cosmos-sdk
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
style: lint go and markdown (cosmos#10060)
## Description + fixing `x/bank/migrations/v44.migrateDenomMetadata` - we could potentially put a wrong data in a new key if the old keys have variable length. + linting the code Putting in the same PR because i found the issue when running a linter. Depends on: cosmos#10112 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
- Loading branch information
1 parent
bc3cda6
commit 479485f
Showing
59 changed files
with
197 additions
and
178 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,11 +23,13 @@ discussion or proposing code changes. To ensure a smooth workflow for all | |
contributors, the general procedure for contributing has been established: | ||
|
||
1. Start by browsing [new issues](https://github.com/cosmos/cosmos-sdk/issues) and [discussions](https://github.com/cosmos/cosmos-sdk/discussions). If you are looking for something interesting or if you have something in your mind, there is a chance it was has been discussed. | ||
- Looking for a good place to start contributing? How about checking out some [good first issues](https://github.com/cosmos/cosmos-sdk/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22)? | ||
|
||
- Looking for a good place to start contributing? How about checking out some [good first issues](https://github.com/cosmos/cosmos-sdk/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22)? | ||
|
||
2. Determine whether a GitHub issue or discussion is more appropriate for your needs: | ||
1. If want to propose something new that requires specification or an additional design, or you would like to change a process, start with a [new discussion](https://github.com/cosmos/cosmos-sdk/discussions/new). With discussions, we can better handle the design process using discussion threads. A discussion usually leads to one or more issues. | ||
2. If the issue you want addressed is a specific proposal or a bug, then open a [new issue](https://github.com/cosmos/cosmos-sdk/issues/new/choose). | ||
3. Review existing [issues](https://github.com/cosmos/cosmos-sdk/issues) to find an issue you'd like to help with. | ||
1. If want to propose something new that requires specification or an additional design, or you would like to change a process, start with a [new discussion](https://github.com/cosmos/cosmos-sdk/discussions/new). With discussions, we can better handle the design process using discussion threads. A discussion usually leads to one or more issues. | ||
2. If the issue you want addressed is a specific proposal or a bug, then open a [new issue](https://github.com/cosmos/cosmos-sdk/issues/new/choose). | ||
3. Review existing [issues](https://github.com/cosmos/cosmos-sdk/issues) to find an issue you'd like to help with. | ||
3. Participate in thoughtful discussion on that issue. | ||
4. If you would like to contribute: | ||
1. Ensure that the proposal has been accepted. | ||
|
@@ -38,7 +40,7 @@ contributors, the general procedure for contributing has been established: | |
to begin work. | ||
5. To submit your work as a contribution to the repository follow standard GitHub best practices. See [pull request guideline](#pull-requests) below. | ||
|
||
**Note: ** For very small or blatantly obvious problems such as typos, you are | ||
**Note:** For very small or blatantly obvious problems such as typos, you are | ||
not required to an open issue to submit a PR, but be aware that for more complex | ||
problems/features, if a PR is opened before an adequate design discussion has | ||
taken place in a GitHub issue, that PR runs a high likelihood of being rejected. | ||
|
@@ -52,14 +54,14 @@ The developers are organized in working groups which are listed on a ["Working G | |
The important development announcements are shared on [Discord](https://discord.com/invite/cosmosnetwork) in the \#dev-announcements channel. | ||
|
||
To synchronize we have few major meetings: | ||
|
||
+ Architecture calls: bi-weekly on Fridays at 14:00 UTC (alternating with the grooming meeting below). | ||
+ Grooming / Planning: bi-weekly on Fridays at 14:00 UTC (alternating with the architecture meeting above). | ||
+ Cosmos Community SDK Development Call on the last Wednesday of every month at 17:00 UTC. | ||
+ Cosmos Roadmap Prioritization every 4 weeks on Tuesday at 15:00 UTC (limited participation). | ||
|
||
If you would like to join one of those calls, then please contact us on [Discord](https://discord.com/invite/cosmosnetwork) or reach out directly to Cory Levinson from Regen Network ([email protected]). | ||
|
||
|
||
## Architecture Decision Records (ADR) | ||
|
||
When proposing an architecture decision for the Cosmos SDK, please start by opening an [issue](https://github.com/cosmos/cosmos-sdk/issues/new/choose) or a [discussion](https://github.com/cosmos/cosmos-sdk/discussions/new) with a summary of the proposal. Once the proposal has been discussed and there is rough alignment on a high-level approach to the design, the [ADR creation process](https://github.com/cosmos/cosmos-sdk/blob/master/docs/architecture/PROCESS.md) can begin. We are following this process to ensure all involved parties are in agreement before any party begins coding the proposed implementation. If you would like to see examples of how these are written, please refer to the current [ADRs](https://github.com/cosmos/cosmos-sdk/tree/master/docs/architecture). | ||
|
@@ -70,11 +72,11 @@ When proposing an architecture decision for the Cosmos SDK, please start by open | |
- `master` must never fail `make lint test test-race`. | ||
- No `--force` onto `master` (except when reverting a broken commit, which should seldom happen). | ||
- Create a branch to start a wok: | ||
- Fork the repo (core developers must create a branch directly in the Cosmos SDK repo), | ||
- Fork the repo (core developers must create a branch directly in the Cosmos SDK repo), | ||
branch from the HEAD of `master`, make some commits, and submit a PR to `master`. | ||
- For core developers working within the `cosmos-sdk` repo, follow branch name conventions to ensure a clear | ||
- For core developers working within the `cosmos-sdk` repo, follow branch name conventions to ensure a clear | ||
ownership of branches: `{moniker}/{issue#}-branch-name`. | ||
- See [Branching Model](#branching-model-and-release) for more details. | ||
- See [Branching Model](#branching-model-and-release) for more details. | ||
- Be sure to run `make format` before every commit. The easiest way | ||
to do this is have your editor run it for you upon saving a file (most of the editors | ||
will do it anyway using a pre-configured setup of the programming language mode). | ||
|
@@ -92,10 +94,12 @@ Tests can be executed by running `make test` at the top level of the Cosmos SDK | |
### Pull Requests | ||
|
||
Before submitting a pull request: | ||
|
||
- merge the latest master `git merge origin/master`, | ||
- run `make lint test` to ensure that all checks and tests pass. | ||
|
||
Then: | ||
|
||
1. If you have something to show, **start with a `Draft` PR**. It's good to have early validation of your work and we highly recommend this practice. A Draft PR also indicates to the community that the work is in progress. | ||
Draft PRs also helps the core team provide early feedback and ensure the work is in the right direction. | ||
2. When the code is complete, change your PR from `Draft` to `Ready for Review`. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
//go:build !libsecp256k1 | ||
// +build !libsecp256k1 | ||
|
||
package secp256k1 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,6 @@ | ||
//go:build !cgo || !ledger | ||
// +build !cgo !ledger | ||
|
||
// test_ledger_mock | ||
|
||
package ledger | ||
|
Oops, something went wrong.