-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes broken install of dev-requirements on apple silicon (Apple M1 Macbook Pro) #326
Conversation
…stalled conda, made a new env, installed scipy via conda (since installing scipy via pip tries compiling numpy on apple silicon which fails), and then try pip installing sb3 requirements, and that fails because apparently torch 1.9.1 is not available on MacOS w/ apple silicon?, but 1.9.0 is!
Also, interestingly, after installing scipy via conda, and then running
Then, if i follow these instructions, i.e. after I run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for fixing those string.
As discussed, before merge maybe we unify the sb3 torch requirements to also use 1.10.2 because that seems to work and has an M1 wheel?
pip uninstall grpcio; conda install grpci
Also, how hard would it be to make install_requirements.py
script automatically do this uninstall/reinstall on M1s? Or does that assume too much about the environment (e.g. conda existing).
I changed updated the sb3 torch requirement to 1.10.2 and updated I also noticed a conflict with the gym requirements between sb3 (which wants <0.20) and rllib_agent (which wants 0.21.0) so I changed rllib_agent to use 0.19.0 and tested that it didn't break anything on my Macbook. |
Up until now, on my Macbook Pro M1 I've been ignoring the rllib tests which have failed with a segfault.
However I recently:
so this changes the version of torch in the example_agent requirements.txt file to 1.9.0, which fixes the error on my Macbook Pro (MBP) M1.
Also, this PR updates the string we look for in sys.platform from "windows" to "win32". I looked at the test output on the github workflow windows machine and it was showing:
Which seemed odd since I would expect it to be matching "windows", so I looked it up and per https://docs.python.org/3/library/sys.html?highlight=sys#sys.platform "win32" is the correct string, not "windows".
So this PR also fixes our use of that string in two example_agent requirements.txt files.