VirtualEnv can be created from setup.py files #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alright @andyk, this should be ready for review! |
nickjalbert
changed the title
andyk
approved these changes
Mar 9, 2022
| """ | ||
| This command clears all virtual environments that have been cached by | ||
| AgentOS in your local file system. All the virtual environments can be | ||
| automatically recreated when re-running a Component ``requirements_path`` |
There was a problem hiding this comment.
Nit: missing "with" in "re-running a Component with `requirements_path` specified."
| def clear_repo_cache(assume_yes): | ||
| """ | ||
| This command clears all git repos that have been cached by AgentOS on your | ||
| local file system. These repos will be recreated if as you run Components |
There was a problem hiding this comment.
Nit: extra "if" in "These repos will be recreated if as you run..."
| for req_path in c.requirements_path.split(";"): | ||
| full_req_path = self.repo.get_local_file_path( | ||
| c.identifier.version, req_path | ||
| ).absolute() |
There was a problem hiding this comment.
Would it make sense to assert that the requirements_file exists here?
This was referenced Mar 10, 2022
Merged
Closed
This was referenced Mar 25, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows virtual environments to be created based on the
install_requireskwarg found insetup.pyfiles. Also included in this PR:More cache-clearing commands:
agentos clear-env-cacheagentos clear-repo-cacheagentos clear-cache # clears both env and repo cacheYou can list multiple requirements files (Python package
setup.pyfiles or pip-compatiblerequirements.txtfiles) in therequirements_pathComponent spec key separated by a semicolon and all will be installed into the virtual env.Update to
rllib_agentandsb3_agentrequirements.Minor improvements to the
install_requirements.pyenvironment setup script.Remove unneeded requirements from AgentOS
setup.py.Try the following demo in your Python REPL to get a Policy class component out of Ilya's repo:
Fixes #275.