-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate VirtualEnv Management into Component #280
Comments
This was referenced Mar 1, 2022
Excellent! Happy to chat about the design a little more too if that would be helpful. |
nickjalbert
added a commit
to nickjalbert/agentos
that referenced
this issue
Mar 3, 2022
nickjalbert
added a commit
to nickjalbert/agentos
that referenced
this issue
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now, the virtualenv management is completely separated from the Component lifecycle. For example, in the CLI, we:
However, there's duplicate work going on here because to get the virtualenv (step 1), we need to construct the Component DAG to find all the requirements files associated with the Components. That DAG then gets tossed and then reconstructed in step 3 to get Component.
This implementation was chosen due to some awkwardness around Component instantiation: you need the virtualenv before you import the managed class, and currently Component eagerly imports the managed class in a way that makes it difficult to fully construct the virtualenv beforehand.
However, with the changes proposed in #276, virtualenv management becomes much cleaner as something that happens completely within the Component. This also makes REPL based demos cleaner.
The text was updated successfully, but these errors were encountered: