Add strict-mode proxy wrapper #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
reviewed
Aug 14, 2017
lib/strictProxy.js
Outdated
| // if (name === 'nodeType') return undefined | ||
|
|
||
| const val = envObj[name] | ||
| if (val === undefined) { |
There was a problem hiding this comment.
Use hasOwnProperty instead?
lib/strictProxy.js
Outdated
|
|
||
| const val = envObj[name] | ||
| if (val === undefined) { | ||
| throw new Error(`Environment var not found: ${name}`) |
There was a problem hiding this comment.
Add [envalid] prefix here as well, to be consistent
|
@SimenB Great feedback, thanks! Last commit should address both points |
SimenB
approved these changes
Aug 14, 2017
lib/strictProxy.js
Outdated
| // if (name === 'nodeType') return undefined | ||
|
|
||
| const varExists = envObj.hasOwnProperty(name) | ||
| if (!varExists) { |
lib/strictProxy.js
Outdated
| const varExists = envObj.hasOwnProperty(name) | ||
| if (!varExists) { | ||
| throw new Error(`[envalid] Environment var not found: ${name}`) | ||
| } else { |
|
Thanks! |
|
@af could you do a publish? (I guess it's a major unless it's moved away from |
|
@af now that those are closed, anything else you want to get done before release? |
|
@SimenB just your prettier PR now I guess :) |
|
Woo |
|
@SimenB 4.0.0 is live! Thanks for all your help :) |
|
Awesome! Looking forward to Monday and deleting some code 🙂 |
|
🎉 |
|
\o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43. @SimenB could you double check this? You have push access now so feel free to merge it too if it looks good :)