Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix etcd install #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Karabass-OFF
Copy link

@Karabass-OFF Karabass-OFF commented Sep 27, 2024

ETCD was not always installed when selecting install. Added API availability check after ETCD installation request.

Summary by CodeRabbit

  • New Features

    • Introduced a retry mechanism for the talosctl bootstrap command to enhance reliability during node bootstrapping.
    • Added a check for port 50000 to ensure ETCD is installed before proceeding with bootstrapping.
  • Bug Fixes

    • Improved error handling by providing a dialog message if ETCD is not installed after maximum retry attempts.

ETCD was not always installed when selecting install. Added API availability check after ETCD installation request.
Copy link

coderabbitai bot commented Sep 27, 2024

Walkthrough

The changes implement a retry mechanism for the talosctl bootstrap command in the talos-bootstrap script. When the should_bootstrap condition is satisfied, the script checks if port 50000 on the specified VIP address is open using nmap. It retries the bootstrap process up to 20 times with a 5-second interval if the port is closed. If the port remains closed after all attempts, a message is shown indicating that ETCD is not installed, and the script exits with a status of 1.

Changes

Files Change Summary
talos-bootstrap script Added a retry mechanism for talosctl bootstrap, including port checks and conditional exits.

Poem

In the land of code, where rabbits play,
A bootstrap dance keeps errors at bay.
With retries galore and nmap in hand,
We check for ETCD, just as we planned.
Hopping through scripts, with joy we embrace,
A smoother start for our digital space! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between b6858d1 and eb30f2e.

📒 Files selected for processing (1)
  • talos-bootstrap (1 hunks)

talos-bootstrap Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant