Add PDB to EtcdCluster spec and implement validation webhhoks #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After discussion with @Kirill-Garbar we decided to recheck spec with the spec of k8s PDB and implement creating resource as there might be hidden problems |
lllamnyp
reviewed
Mar 29, 2024
sircthulhu
force-pushed
the
feature/61-enable-pdb
branch
from
67474c9 to
b3c578a
Compare
sergeyshevch
requested changes
Apr 1, 2024
sircthulhu
force-pushed
the
feature/61-enable-pdb
branch
from
b3c578a to
248b31f
Compare
|
@Kirill-Garbar could you please review this? |
6 tasks
sircthulhu
force-pushed
the
feature/61-enable-pdb
branch
from
17cd5ea to
2cb3ae9
Compare
Kirill-Garbar
approved these changes
Apr 2, 2024
kvaps
added a commit
that referenced
this pull request
Apr 22, 2024
fix regression introduced by #93 Helm chart missing privileges to operate poddisruptionbudgets Signed-off-by: Andrei Kvapil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added PDB to spec, implemented webhooks and tests.
Fixes #61