Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHA docker publish pipeline #4

Merged
merged 6 commits into from
Mar 10, 2024
Merged

GHA docker publish pipeline #4

merged 6 commits into from
Mar 10, 2024

Conversation

hiddenmarten
Copy link
Member

No description provided.

@hiddenmarten hiddenmarten changed the title GHA pipeline draft GHA pipeline Mar 9, 2024
@hiddenmarten hiddenmarten changed the title GHA pipeline GHA docker push pipeline Mar 9, 2024
AlexGluck
AlexGluck requested changes Mar 9, 2024
View reviewed changes
Copy link
Collaborator

@AlexGluck AlexGluck left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used version ubuntu must be static, example 22.04 not latest. When release new version ubuntu behaviour can be change and functionality ci will be broken.

AlexGluck
AlexGluck reviewed Mar 9, 2024
View reviewed changes
Copy link
Collaborator

@AlexGluck AlexGluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image tags set latest, how users can find correct version? May be we can add calver in iso8601 format? Add git hash short and full commit hash? Semver? Mixed variations?

@hiddenmarten
Copy link
Member Author

hiddenmarten commented Mar 10, 2024 •
edited
Loading

Thanks for the suggestions, I really appreciate it.
Keep in mind it's just a draft, it's not ready for review yet :)

@hiddenmarten
Copy link
Member Author

Just took a GHA example and made some minor changes.

I think the real pipeline should be implemented after the discussion about versioning and all of this stuff.

@hiddenmarten hiddenmarten marked this pull request as ready for review March 10, 2024 08:39
@hiddenmarten hiddenmarten requested a review from AlexGluck March 10, 2024 08:39
@hiddenmarten hiddenmarten changed the title GHA docker push pipeline GHA docker publish pipeline Mar 10, 2024
kvaps
kvaps requested changes Mar 10, 2024
View reviewed changes
Copy link
Member

@kvaps kvaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hiddenmarten pleaase make sure that pipeline works normally on other github repo.
You have to push changes to main, and try creating tag.

Eg. I tried to run it on https://github.com/kvaps/etcd-operator and https://github.com/kvaps/etcd-operator2 both didn't work

@hiddenmarten hiddenmarten marked this pull request as draft March 10, 2024 09:26
@hiddenmarten
Copy link
Member Author

hiddenmarten commented Mar 10, 2024 •
edited
Loading

Now it works on my side:

https://github.com/hiddenmarten/etcd-operator/actions/runs/8221133878
https://github.com/hiddenmarten/etcd-operator/pkgs/container/etcd-operator

@hiddenmarten hiddenmarten requested a review from kvaps March 10, 2024 10:03
@hiddenmarten hiddenmarten marked this pull request as ready for review March 10, 2024 10:03
kvaps
kvaps approved these changes Mar 10, 2024
View reviewed changes
Copy link
Member

@kvaps kvaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my side LGTM.

To reviewers: please use "Squash & Merge" for this PR

@kvaps kvaps enabled auto-merge (squash) March 10, 2024 10:25
@kvaps kvaps merged commit d18bf37 into main Mar 10, 2024
AlexGluck pushed a commit that referenced this pull request Mar 11, 2024
@hiddenmarten @AlexGluck
GHA docker publish pipeline (#4)
ed538df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexGluck AlexGluck AlexGluck approved these changes

@kvaps kvaps kvaps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hiddenmarten @kvaps @AlexGluck