Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set extraArgs in the end of args processing #250

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

makhov
Copy link
Contributor

@makhov makhov commented Jul 10, 2024

Set extraArgs in the end of args processing to let them overwrite default values

@makhov makhov force-pushed the fix-extra-args-order branch from dbab586 to 06b3066 Compare July 10, 2024 06:45
@makhov makhov marked this pull request as ready for review July 10, 2024 09:55
@sircthulhu sircthulhu added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 11, 2024
Copy link
Member

@sircthulhu sircthulhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sircthulhu sircthulhu merged commit d3f1892 into aenix-io:main Jul 12, 2024
11 checks passed
@kvaps kvaps added this to the v0.4.0 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controllers ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants