Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set quota-backend-bytes to 95% of requested size #217

Merged
merged 2 commits into from
May 30, 2024
Merged

feat: set quota-backend-bytes to 95% of requested size #217

merged 2 commits into from
May 30, 2024

Conversation

sircthulhu
Copy link
Member

  • Changed ENVTEST_K8S_VERSION to 1.30.0 as there's no tool chains for version 1.30.1
  • Implemented auto setting quota-backend-bytes for requested PVC / emptyDir size

Possible problems:

  • After changing requested size, option quota-backend-bytes will be left unchanged

fixes #211

@sircthulhu sircthulhu added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. feature New feature or request labels May 19, 2024
@sircthulhu sircthulhu requested a review from Kirill-Garbar as a code owner May 19, 2024 07:59
@sircthulhu sircthulhu force-pushed the feat/211-quota-backend-bytes branch from c58df53 to f751a69 Compare May 19, 2024 08:57
@sircthulhu sircthulhu requested a review from sergeyshevch as a code owner May 19, 2024 08:57
sergeyshevch
sergeyshevch approved these changes May 21, 2024
View reviewed changes
internal/controller/factory/statefulset.go Outdated Show resolved Hide resolved
@sircthulhu sircthulhu force-pushed the feat/211-quota-backend-bytes branch from d60292e to 794e669 Compare May 30, 2024 15:01
@sircthulhu sircthulhu enabled auto-merge (squash) May 30, 2024 15:01
@sircthulhu sircthulhu merged commit 349c688 into main May 30, 2024
9 checks passed
@sircthulhu sircthulhu deleted the feat/211-quota-backend-bytes branch May 30, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddenmarten hiddenmarten hiddenmarten approved these changes

@sergeyshevch sergeyshevch sergeyshevch approved these changes

@Kirill-Garbar Kirill-Garbar Awaiting requested review from Kirill-Garbar Kirill-Garbar is a code owner

Assignees
No one assigned
Labels
controllers feature New feature or request ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automatically set quota-backend-bytes option to 95% from requested size:
3 participants
@sircthulhu @sergeyshevch @hiddenmarten