feat: introduce containers and volumes in podTemplate #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sircthulhu
requested review from
Kirill-Garbar,
sergeyshevch,
hiddenmarten and
AlexGluck
as code owners
kvaps
reviewed
Apr 3, 2024
sircthulhu
force-pushed
the
feat/113-spec-containers
branch
from
1fb739a to
8a61995
Compare
sergeyshevch
requested changes
Apr 4, 2024
sircthulhu
force-pushed
the
feat/113-spec-containers
branch
from
8a61995 to
69eb289
Compare
sergeyshevch
approved these changes
Apr 4, 2024
Kirill-Garbar
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's obvious constraint: user cannot add PVC's with
ReadWriteOnceorReadWriteOncePodto pods as they should be included in statefulset's volumeClaimTemplates or should have extra option in case of custom pod controllerfixes #113