[WIP] Feature/quick review of hosting patches

[helmo]

I'd like to 'abuse' this branch continued review.

Most commits will have a Drupal.org issue number included, please leave any comments there.

See also:

• [WIP] Feature/quick review hostmaster#5
• [WIP] Feature/quick review of provision patches provision#11

[jonpugh]

@helmo how about just name the branch review or patch-review then? It's hardly a feature ;)

[jonpugh]

I restarted the build

[jonpugh]

It's the git log --oneline -n1 command. It keeps the terminal open. I'm rusty with bash. Make sure the git log command only outputs, not follows.

[jonpugh]

https://github.com/aegir-project/hosting/commits/7.x-3.x/.travis.yml

See the red dot? beware, unless we lock the branch, we can push failing code.

[jonpugh]

I guess i'm not sure! sorry, very tired, typing with one hand

[helmo]

On 25-10-16 17:24, Jon Pugh wrote:

@helmo https://github.com/helmo how about just name the branch
|review| or |patch-review| then? It's hardly a feature ;)

True ;)

I guess i'm not sure! sorry, very tired, typing with one hand

Hope your more rested now ....

The "git log --oneline -n1" command is not something that follows, it
just outputs oneline... as I understand it :)

But anyway, I removed it and it now turned green :)

[helmo]

WTF ... the commit after the one where I introduced that debug line passed.

https://travis-ci.org/aegir-project/hosting/builds/169495658

But after cherry-picking two commits to 7.x-3.x it failed the tests...
and now removed the debug line there and it passed again ....