Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoconf / m4 update #24

Merged
merged 4 commits into from
Apr 3, 2023
Merged

autoconf / m4 update #24

merged 4 commits into from
Apr 3, 2023

Conversation

mywave82
Copy link
Contributor

@mywave82 mywave82 commented Apr 1, 2023

  • Split up acinclude.m4 into separate m4 files makes it easier to maintain
  • update the .m4 files
  • Add regen.sh for persons who are not experient in automake/autoconf

This is one of the details pointed out in #23 by @dmitrysmagin

@Malvineous
Copy link
Member

Is regen.sh better than running autoreconf?

@mywave82
Copy link
Contributor Author

mywave82 commented Apr 2, 2023

Is regen.sh better than running autoreconf?

I followed a guide that probably was outdated, but which commands autoreconf implies probably depends on the version of it, and considering we have bugreports about gcc 4.x toolchain issues in adplug I guess it didn't hurt.

@mywave82
Copy link
Contributor Author

mywave82 commented Apr 2, 2023

Also autoreconf fails if you are changing m4 stuff and already have existing Makefile. Then you either need to purge manually or run the commands manually as implied in ./regen.sh

(testing out replacing the outdated getopt files with using libgnu tools, so experiences these edge cases while in process)

@Malvineous
Copy link
Member

Interesting, fair enough. I'm no expert but I assumed autoreconf was supposed to avoid the need for a shell script, but if it doesn't work, then I have no problem with the shell script.

The main AdPlug readme has for a long time suggested to run autoreconf --install - I presume that doesn't fare any better in those situations you mention?

@mywave82
Copy link
Contributor Author

mywave82 commented Apr 2, 2023

autoreconf --install should work for most use-cases, but if there any failures or autotools stop working while hacking on it, the steps inside ./regen.sh should get you back on-track.

I can update readme to include that later (I'm about to log off)

@mywave82
Copy link
Contributor Author

mywave82 commented Apr 2, 2023

Just merged info from regen.sh into README instead

@mywave82 mywave82 merged commit 0a7e6f7 into adplug:master Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants