Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leaf detection when merging sibling keys #466

Merged
merged 2 commits into from
May 3, 2020
Merged

Leaf detection when merging sibling keys #466

merged 2 commits into from
May 3, 2020

Conversation

snewcomer
Copy link
Collaborator

close #229

👋 @bterkuile

@snewcomer snewcomer self-assigned this May 3, 2020
@bterkuile
Copy link

Nice! I checked out the sn/leaf-detectin branch an replaced the node_modules/ember-changeset folder for this code. For the real life test I am performing it works!

@snewcomer snewcomer merged commit c1de2be into master May 3, 2020
@snewcomer snewcomer deleted the sn/leaf-detectin branch May 3, 2020 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snewcomer snewcomer

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'getting' a Moment instance on a changeset returns a relay instead of that instance
2 participants
@snewcomer @bterkuile