New Mobile gnav 1.2 redesign #3374
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bandana147
added
high-impact
bandana147
requested review from
salonijain3,
sharmrj,
nishantka,
Deva309 and
sonawanesnehal3
as code owners
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3374 +/- ##
==========================================
+ Coverage 96.48% 98.74% +2.26%
==========================================
Files 254 77 -177
Lines 59031 9710 -49321
==========================================
- Hits 56954 9588 -47366
+ Misses 2077 122 -1955 ☔ View full report in Codecov by Sentry. |
…3092) * basic functionality of mobile gnav * Made the localnav sticky, and the gnav not sticky when there is a local nav * Local nav now resides outside header to make it sticky correctly * fixed a few small css details when opening and closing the mega menu * render the mainmenu on non local nav pages and the brand icon on local nav pages on the mega menu * don't show local nav unless it's in the right place
* fix the popup showing up for a split second when the hamburger menu is first opened * Undid the previous commit because it didn't work * switched out animations to transitions for fedspopup * Made section buttons have a margin while regular navlinks occupy the whole space * Fixed section menu spacing * Spacing of section after navlink on adobe home * Like the previous commit but actually works * divider line * changed last of kind to last of type * fixed divider spacing * link spacing * we need to pad the last nav link as well * nav link font size * rules apply only to the links not the sections * fixed the selector for the previous commit * I sure hope it works this time * Fixed the navLinks in light mode
* Breadcrumbs design change * Hide breadcrumbs on first sidebar * Fixing no breadcrumbs page * Fixing css
* Adding main menu placeholder * Avoiding replaceText if localNav * Lint fix
* Keyboard navigation for mobile gnav redesign * close main menu on escape * fixed lint issue
* Localnav design and event listeners * Lint fix * Adding Overview title support
* Handling CLS issue by preserving space for localnav * Adding localnav config * Adding overview text from placeholder * Adding meta data check for new mobile gnav feature flag * Lint fix * Adding localnav only when mobile gnav v2 is true
* Adding image support on gnav * Decorating localnav only if it has one section * Lint fix
* Check for localnav * Moving getGnanSource to utils * Awaiting gnav source * Adding lanalog when there is mismatch with content and name * Lint fixes * Changing height of localnav
@mokimo Can you retry again? It opens up like this for me - |
|
Yes works now! |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
bandana147
force-pushed
the
mobile-gnav
branch
from
cfb6075 to
ee0dc32
Compare
… iphone 15 in landscape and portrait mode (#3390) * changed vh to dvh (for iphones) * made localnav curtain height lvh instead of dvh * gave localnav curtain a min height of webkit fill available * missed a semicolon * padded localnav curtain with safe-area-inset-bottom * made local nav curtain slightly larger than the view port to prevent a small space that allows clicking on the bottom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-156956
Test URLs:
QA: