Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-158537 : Upgrade Universal Nav to version 1.4 #3367

Open
wants to merge 7 commits into
base: stage
Choose a base branch
from

Conversation

sonawanesnehal3
Copy link
Contributor

Upgrade Universal Nav to version 1.4

  • Add messageEventListener to avoid onMessage event listener (Ref)
  • Support Profile Switching in Account Menu (Ref1, Ref2)
  • Support new Mobile UX designs for Unav (Ref)
  • Enable shopping cart (Ref)

Resolves: MWPW-158537

Test URLs:

@sonawanesnehal3 sonawanesnehal3 added do not merge PR should not be merged yet needs-verification PR requires E2E testing by a reviewer labels Dec 12, 2024
Copy link
Contributor

aem-code-sync bot commented Dec 12, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@sonawanesnehal3 sonawanesnehal3 removed the do not merge PR should not be merged yet label Dec 12, 2024
Copy link
Contributor

aem-code-sync bot commented Dec 12, 2024

Page Scores Audits Google
📱 /drafts/snehal/illustrator?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/snehal/illustrator?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.48%. Comparing base (6f4d98c) to head (6e302d7).
Report is 151 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3367      +/-   ##
==========================================
+ Coverage   96.37%   96.48%   +0.11%     
==========================================
  Files         245      254       +9     
  Lines       56716    59043    +2327     
==========================================
+ Hits        54661    56969    +2308     
- Misses       2055     2074      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonawanesnehal3 sonawanesnehal3 changed the title Upgrade Universal Nav to version 1.4 MWPW-158537 : Upgrade Universal Nav to version 1.4 Dec 12, 2024
@sonawanesnehal3 sonawanesnehal3 added needs-verification PR requires E2E testing by a reviewer and removed needs-verification PR requires E2E testing by a reviewer labels Dec 12, 2024
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-verification PR requires E2E testing by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants