[Release] Stage to Main #3355
Open
[Release] Stage to Main #3355
+1,889
−482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![milo-pr-merge[bot]](https://avatars.githubusercontent.com/u/95242840?s=60&v=4){kind=small}
* initial publish * first commit * cleaned up * fixed id dupes * tighten up accordion height, increase width * Add source * Remove shown * Fix freshManifest source * committing better version not neat * added divs to dropdowns * stab at data parse for db * refine parseMepConfig * align to db, improve form look, add event listeners * stop using block name constant * update to aws api * Unfinished code for Viv * Fix undefined manifest * Add back properties and fix small DOM issue * Add get getMepPopup * stash * save working * Confine listeners to current meplist * add url param and hash method for sharing * just omit promos out of date range * minor fixes and checks * add condition for mepHighlight * pulling in manifest info * don't show arrow on mep panel in mmm * refactor functions * Fix radio and preview buttons * Remove comment * Fix typo * rework share logic fix spacing color * fix merge conflict bug * fix merge conflict created bug * Add another pageId * Fix label click issue * Fix pencil issue * bunch of fixes * deep link * add conditional chaining * refactor and streamline * update now that pathname is sent by db * fix page search for new db structure * switch to full field name not first letter * change all to empty * top geos and top pages * remove line * fix breaking from merge * loops through filters instead of hard code * keep share button on right in mobile * no longer using form.html * default all doesn't need to be in Word * share button on top * create shareButton listeners at creation * rename functions * remove unneeded files * restore fix to update button * change served to found * add change listener to input * unit tests working * button back but not visible * button fixed * add sharebutton unit test * fix share button test * repair existing unit tests * update mmm test after other fixes * collapse all when new one opened * update to new db column names * fix issue with preview link including entire manifest url instead of just path * fix activites filter in saveToMmm * add source for mep param, fix filter for save * fix radio buttons to only use path * duplicate schedule info * mmmremovemepsource * fix page save and analyticsTitle * tweak placeholder helpful info * Fix code scanning alert no. 235: Incomplete URL substring sanitization Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * remove unused * tweak to suggested security fix * unit test update * curious what the security check says * revert * remove authorization * lint issue * simplify milo check * add source to default promo shell... again * update css rule for add manifest input * hide scheduled info in mmm * remove unused import and return error message --------- Co-authored-by: viloria <[email protected]> Co-authored-by: markpadbe <[email protected]> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…fix (#3318) * Adding dynamic-nav-group setting to allow distinction between dynamic-nav user journeys * Utils change * Ensuring status shows correctly dispite group * Making metadata case insensative * Does a check for status.js if storage item does not exist --------- Co-authored-by: Megan Thomas <[email protected]>
* cta color hover change * cta color hover change * cta color hover change --------- Co-authored-by: Suhani <[email protected]>
|
Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot |
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3355 +/- ##
==========================================
+ Coverage 96.43% 96.48% +0.04%
==========================================
Files 253 254 +1
Lines 58761 59031 +270
==========================================
+ Hits 56669 56954 +285
+ Misses 2092 2077 -15 ☔ View full report in Codecov by Sentry. |
Fix optional profile page detail
* MWPW-157864 [Catalog] Localise external modals * MWPW-157864 [Catalog] Localise external modals * MWPW-157864 [Catalog] Localise external modals * Trigger Build --------- Co-authored-by: Bozo Jovicic <[email protected]>
mokimo
approved these changes
Dec 11, 2024
* Adding video fill variant * PR feedback, css clean up * Fixing code conflicts with #3053 --------- Co-authored-by: Ryan Clayton <[email protected]>
* Adds marketo forms2.min.js to dependencies, upates dependency workflow, updates marketo.js to call form from correct location * Adding comment for git change only * Adding comment to hopefully see change * Removing comments * Typo * Updating PR description * Fixing tests
milo-pr-merge
bot
requested review from
Brandon32 and
meganthecoder
as code owners
hadobe
approved these changes
Dec 16, 2024
aem-code-sync
bot
had a problem deploying
to
feds-standalone-v0.0.2-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common base root URLs
Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html
Milo: