-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TNT-46700 Add proxy configuration #116
Changes from 2 commits
e773710
4f4d13c
35e3f73
c3521b8
a32f701
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,5 +27,8 @@ | |
"lerna": "^4.0.0", | ||
"prettier": "^2.7.1", | ||
"pretty-quick": "^3.1.3" | ||
}, | ||
"dependencies": { | ||
"undici": "^5.18.0" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,5 +1,6 @@ | ||||||
import { DecisioningArtifact } from "./DecisioningArtifact"; | ||||||
import { ParseDomainFunc } from "./DecisioningContext"; | ||||||
import { ProxyAgent } from "undici"; | ||||||
|
||||||
export interface DecisioningConfig { | ||||||
/** | ||||||
|
@@ -86,4 +87,9 @@ export interface DecisioningConfig { | |||||
* Function used to parse domains | ||||||
*/ | ||||||
parseDomainImpl?: ParseDomainFunc; | ||||||
|
||||||
/** | ||||||
* Proxy Agent to specify a proxy for the fetch implementation | ||||||
*/ | ||||||
proxyAgent: ProxyAgent; | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should probably also be nullable
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need to add There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. undici fetch is expecting an There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest simplifying a bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for consistency let's use
isDefined
please.