Skip to content

Commit

Permalink
Upgrade to node 14 (#2027)
Browse files Browse the repository at this point in the history
* Upgrade to node 16

* be more specific with our version and use the new recommended image

* move to 14, once we upgrade parcel, maybe we can go to 16

* fix format number resolved options

14.17 introduced a breaking change where resolvedOptions returns 'decimal' instead of 'percent'. I've logged a bug here:
nodejs/node#39050
  • Loading branch information
snowystinger authored Jun 29, 2021
1 parent b2b2935 commit d1645fb
Showing 1 changed file with 35 additions and 85 deletions.
120 changes: 35 additions & 85 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -1,15 +1,35 @@
version: 2.1

orbs:
azure-cli: circleci/[email protected]
jobs:
install:

executors:
rsp:
docker:
- image: circleci/node:12
- image: cimg/node:14.16
environment:
CACHE_VERSION: v1
working_directory: ~/react-spectrum

rsp-large:
docker:
- image: cimg/node:14.16
resource_class: large
environment:
CACHE_VERSION: v1
working_directory: ~/react-spectrum

rsp-xlarge:
docker:
- image: cimg/node:14.16
resource_class: xlarge
environment:
CACHE_VERSION: v1
working_directory: ~/react-spectrum

jobs:
install:
executor: rsp-large
steps:
- checkout
- restore_cache:
Expand Down Expand Up @@ -41,13 +61,7 @@ jobs:
key: react-spectrum-{{ .Environment.CACHE_VERSION }}-{{ .Environment.CIRCLE_SHA1 }}

install-17:
docker:
- image: circleci/node:12
resource_class: large
environment:
CACHE_VERSION: v1

working_directory: ~/react-spectrum
executor: rsp-large
steps:
- checkout
- restore_cache:
Expand All @@ -67,13 +81,7 @@ jobs:
key: react-spectrum17-{{ .Environment.CACHE_VERSION }}-{{ .Environment.CIRCLE_SHA1 }}

test-ssr:
docker:
- image: circleci/node:12
resource_class: xlarge
environment:
CACHE_VERSION: v1

working_directory: ~/react-spectrum
executor: rsp-xlarge
steps:
- restore_cache:
key: react-spectrum-{{ .Environment.CACHE_VERSION }}-{{ .Environment.CIRCLE_SHA1 }}
Expand All @@ -84,13 +92,7 @@ jobs:

test:
parallelism: 3
docker:
- image: circleci/node:12
resource_class: xlarge
environment:
CACHE_VERSION: v1

working_directory: ~/react-spectrum
executor: rsp-xlarge
steps:
- restore_cache:
key: react-spectrum-{{ .Environment.CACHE_VERSION }}-{{ .Environment.CIRCLE_SHA1 }}
Expand All @@ -115,13 +117,7 @@ jobs:
path: ~/junit

test-ssr-17:
docker:
- image: circleci/node:12
resource_class: xlarge
environment:
CACHE_VERSION: v1

working_directory: ~/react-spectrum
executor: rsp-xlarge
steps:
- restore_cache:
key: react-spectrum17-{{ .Environment.CACHE_VERSION }}-{{ .Environment.CIRCLE_SHA1 }}
Expand All @@ -133,13 +129,7 @@ jobs:
test-17:
parallelism: 3
docker:
- image: circleci/node:12
resource_class: xlarge
environment:
CACHE_VERSION: v1

working_directory: ~/react-spectrum
executor: rsp-xlarge
steps:
- restore_cache:
key: react-spectrum17-{{ .Environment.CACHE_VERSION }}-{{ .Environment.CIRCLE_SHA1 }}
Expand All @@ -162,12 +152,7 @@ jobs:
path: ~/junit

lint:
docker:
- image: circleci/node:12
environment:
CACHE_VERSION: v1

working_directory: ~/react-spectrum
executor: rsp
steps:
- restore_cache:
key: react-spectrum-{{ .Environment.CACHE_VERSION }}-{{ .Environment.CIRCLE_SHA1 }}
Expand All @@ -177,13 +162,7 @@ jobs:
command: yarn lint

storybook:
docker:
- image: circleci/node:12
resource_class: large
environment:
CACHE_VERSION: v1

working_directory: ~/react-spectrum
executor: rsp-large
steps:
- restore_cache:
key: react-spectrum-{{ .Environment.CACHE_VERSION }}-{{ .Environment.CIRCLE_SHA1 }}
Expand All @@ -198,13 +177,7 @@ jobs:
- '*/storybook/'

storybook-17:
docker:
- image: circleci/node:12
resource_class: large
environment:
CACHE_VERSION: v1

working_directory: ~/react-spectrum
executor: rsp-large
steps:
- restore_cache:
key: react-spectrum17-{{ .Environment.CACHE_VERSION }}-{{ .Environment.CIRCLE_SHA1 }}
Expand All @@ -219,13 +192,7 @@ jobs:
- '*/storybook-17/'

docs:
docker:
- image: circleci/node:12
resource_class: xlarge
environment:
CACHE_VERSION: v1

working_directory: ~/react-spectrum
executor: rsp-xlarge
steps:
- restore_cache:
key: react-spectrum-{{ .Environment.CACHE_VERSION }}-{{ .Environment.CIRCLE_SHA1 }}
Expand All @@ -240,13 +207,7 @@ jobs:
- '*/docs/'

docs-production:
docker:
- image: circleci/node:12
resource_class: xlarge
environment:
CACHE_VERSION: v1

working_directory: ~/react-spectrum
executor: rsp-xlarge
steps:
- restore_cache:
key: react-spectrum-{{ .Environment.CACHE_VERSION }}-{{ .Environment.CIRCLE_SHA1 }}
Expand Down Expand Up @@ -282,12 +243,7 @@ jobs:
command: az storage blob upload-batch -d "\$web" -s /tmp/dist/production/docs --account-name reactspectrum

comment:
docker:
- image: circleci/node:12
environment:
CACHE_VERSION: v1

working_directory: ~/react-spectrum
executor: rsp
steps:
- checkout
- restore_cache:
Expand All @@ -301,13 +257,7 @@ jobs:
fi
publish-nightly:
docker:
- image: circleci/node:12
resource_class: xlarge
environment:
CACHE_VERSION: v1

working_directory: ~/react-spectrum
executor: rsp-xlarge
steps:
- restore_cache:
key: react-spectrum-{{ .Environment.CACHE_VERSION }}-{{ .Environment.CIRCLE_SHA1 }}
Expand Down

0 comments on commit d1645fb

Please sign in to comment.